LIVE-2111: Fix wallet recommended section carousel v2 to v3 migration - Githubissues

LedgerHQ / ledger-live-mobile

⛔️ DEPRECATED - Ledger Live (Mobile)

https://ledger.com/live

Apache License 2.0

381 stars 116 forks source link

LIVE-2111: Fix wallet recommended section carousel v2 to v3 migration #2480

Closed ofreyssinet-ledger closed 2 years ago

ofreyssinet-ledger commented 2 years ago

Before:

The recommended section is missing from the Wallet page when updating the app from v2 to v3.

https://user-images.githubusercontent.com/91890529/166658304-5fc5a713-a2fa-45ae-b7b2-189293984bd3.mp4

After:

The recommended section is displayed when updating the app from v2 to v3.

https://user-images.githubusercontent.com/91890529/166658269-e1928840-4e10-4855-b89e-3693e342709a.mp4

Type

Bug fix

Context

Parts of the app affected / Test plan

"Wallet" screen -> "Recommended" section (carousel with cards)

Install v2, go through the onboarding, then install v3 and check that the "Recommended" section is here.

github-actions[bot] commented 2 years ago

Thanks for your contribution. To be able to merge in develop branch, you need to:

[ ] pass the CI
[ ] if needed, run /generate-screenshots
[ ] have a dev review
[ ] have a QA review
[ ] if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes, it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library, once the PR is merged on develop on ledger-live-common side, you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.