LIVE-2119 Bugfix/graph out of bound issue - Githubissues

LedgerHQ / ledger-live-mobile

⛔️ DEPRECATED - Ledger Live (Mobile)

https://ledger.com/live

Apache License 2.0

381 stars 116 forks source link

LIVE-2119 Bugfix/graph out of bound issue #2495

Closed LFBarreto closed 2 years ago

LFBarreto commented 2 years ago

Issue in graphs when values could be out of range due to too big of a difference between min and max Y axis values. d3 lib would then try to create an svg area targeting out of bounds points. A simple switch in the min value to target for the gradient area clears that

Type

Bug Fix

Context

Parts of the app affected / Test plan

github-actions[bot] commented 2 years ago

Thanks for your contribution. To be able to merge in develop branch, you need to:

[ ] pass the CI
[ ] if needed, run /generate-screenshots
[ ] have a dev review
[ ] have a QA review
[ ] if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes, it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library, once the PR is merged on develop on ledger-live-common side, you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.