Closed ofreyssinet-ledger closed 2 years ago
Thanks for your contribution. To be groomed for next release, you need to:
/generate-screenshots
[ ] have a QA review
If your PR contains UI related changes, it might be necessary to regenerate screenshots.
New tab bar / navigation bar with a new animation.
Design ref Animation ref Analytics ref LIVE-1816
READ THIS BEFORE CODE REVIEW PLS 🙏
This includes:
position: absolute
).analytics.js
to easily track an event with thepage
property preset following the navigation state.Android no nano state
https://user-images.githubusercontent.com/91890529/168785372-e61d6e04-dcaf-4a0e-ab2c-e29451d8734b.mp4
Android normal state
sorry, stupid github doesn't let me upload this Video here (GDrive)
iOS normal state
Video here (GDrive)
Type
Feature
Context
LIVE-1816
Parts of the app affected / Test plan
-> Should be careful that the perf is ok on slow phones -> Should be careful that all screens that have the navigation bar visible don't have their bottommost content hidden behind the navigation bar