feedbacks on Add Accounts

[gre]

• I'm not really sure about this idea of Cancel add account modal.
  • First of all it only makes sense to make it on step 3.
  • Secondly there is other ways to quit the add account modal.
  • Thirdly, we don't today prevent all possible ways of leaving this screen: on iOS on can pull down the header to quit the modal. on Android you can press back button. not easy to override these.
• miss padding after the list of crypto so when you scroll to end, the last row is not at the very bottom of the screen.
• I'm not able to import anything because I'm still having derivations.reduce is not a function:

iOS only.

there are actually a lot of bugs on iOS implementation at the moment

[gre]

you can continue with this:

diff --git a/src/libcore/index.js b/src/libcore/index.js
index ec18e67..f7cdb8a 100644
--- a/src/libcore/index.js
+++ b/src/libcore/index.js
@@ -147,20 +147,20 @@ export async function createAccountFromDevice({
   const accountCreationInfos = await core.coreWallet.getNextAccountCreationInfo(
     wallet,
   );
-  const chainCodes = await core.coreAccountCreationInfo.getChainCodes(
-    accountCreationInfos,
+  const chainCodes = getValue(
+    await core.coreAccountCreationInfo.getChainCodes(accountCreationInfos),
   );
-  const publicKeys = await core.coreAccountCreationInfo.getPublicKeys(
-    accountCreationInfos,
+  const publicKeys = getValue(
+    await core.coreAccountCreationInfo.getPublicKeys(accountCreationInfos),
   );
-  const index = await core.coreAccountCreationInfo.getIndex(
-    accountCreationInfos,
+  const index = getValue(
+    await core.coreAccountCreationInfo.getIndex(accountCreationInfos),
   );
-  const derivations = await core.coreAccountCreationInfo.getDerivations(
-    accountCreationInfos,
+  const derivations = getValue(
+    await core.coreAccountCreationInfo.getDerivations(accountCreationInfos),
   );
-  const owners = await core.coreAccountCreationInfo.getOwners(
-    accountCreationInfos,
+  const owners = getValue(
+    await core.coreAccountCreationInfo.getOwners(accountCreationInfos),
   );

   await derivations.reduce(

getValue is a temporary workaround for this.

[meriadec]

thx. looking into it.

[meriadec]

I agree on the cancel modal (there is not for send transaction.. so.. :joy: ), the chances that someone hit the top right close arrow by mistake are near from 0%

[gre]

• select / unselect all hitSlop area is way too small.

[gre]

• navigation.navigate("AddAccountsSuccess", { currency });

use replace instead. the swipe right to left animation is very weird.

[meriadec]

https://github.com/LedgerHQ/ledger-live-mobile/pull/397

[gre]

what about :

• only cancel modal on the step scanning ?

[meriadec]

yeah, I tried to negociate lol

[meriadec]

but no :)

[gre]

ok i'll discuss again