LedgerHQ / ledger-live-mobile

⛔️ DEPRECATED - Ledger Live (Mobile)
https://ledger.com/live
Apache License 2.0
383 stars 115 forks source link

Allow apostrophe when renaming device #909

Open josokinas opened 5 years ago

josokinas commented 5 years ago

Currently app does not allow to use apostrophes when renaming the device - no or ' is allowed. However in English we tend to use such for naming the owner of something, e.g. Tom’s Nano X.

Part of the application

Device management - renaming a device feature.

gre commented 5 years ago

if it's not in ascii alphabet we've chosen not to support it. I guess there is still a ' in ascii and we can be less restrictive (can't remember the code but we probably have a regexp with just alpha num and spaces today, it should be ok to extend it to more)

josokinas commented 5 years ago

If there is no complications, I'd say there should be no restrictions and everything within https://www.kerryr.net/pioneers/ascii3.htm should be allowed. If not possible, then at least such as and ' - as they are, for example, when naming a MacBook on macOS.

gre commented 5 years ago

we're limiting to what the device supports basically (otherwise it won't be able to display it in the NanoX interface itself) and yeah that list of ascii should be fine. i'll check with the team what is the exact list.