search

LedgerHQ / ledger-live

Mono-repository for packages related to Ledger Live and its JavaScript ecosystem.
MIT License
434 stars 327 forks source link

[Feature]: See Produced Blocks in Transaction #3175

Closed jeffersonwarrior closed 1 year ago

jeffersonwarrior commented 1 year ago

Library name

@leadgerhq/ledger-live

Describe your feature request

Within the transaction history, produced blocks should appear as transactions. Currently, produced blocks can be seen on Etherscan but it does not appear in the transaction history or anywhere else within the wallet on Ledger Live.

Other transaction types (ERC 20 tokens and NFT's) do appear, but only produced blocks do not appear. So when a transaction is processed and the suggested fee recipient is set to an addressed used by a Ledger Live ETH wallet, the produced block does not get added to the transaction history.

jeffersonwarrior commented 1 year ago

Hey - so ... the issue is with ledger live and not with something support can deal with. I can provide examples as needed - screenshots - if you're really into that sort of thing. But the bottom line is:

Etherscan "Produced Blocks" will show a produced block. The balance will update.

Ledger Live will NOT show the produced blocks in transaction history. The balance matches Etherscan.

gre commented 1 year ago

Hi @jeffersonwarrior , what do you mean by 'Produced Blocks' ? like a minted block? 👀 indeed an example might be good to see the delta between what the Live do and what is expected.

jeffersonwarrior commented 1 year ago

@gre An example: https://etherscan.io/address/0xc3af24f9d2850d83dbcffc4c35b15c34f84966a2#mine

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

jeffersonwarrior commented 1 year ago

Still an issue - and now even more so with the transfers done from staked nodes to the withdrawal addresses.

jeffersonwarrior commented 1 year ago

Please can someone pick up this issue @gre @stefanv ... It should not be stale / deleted.

adrienlacombe commented 1 year ago

@jeffersonwarrior Ledger never supported staker features so this is an enhancement that might not be considered with high priority by our product team.

jeffersonwarrior commented 1 year ago

@adrienlacombe-ledger Well...so...here's my thinking on this. Ledger has stated that you can "stake your Ethereum" now with Ledger. https://www.ledger.com/staking-ethereum

Now I realize the actual method is a little different than with pure Solo Staking ... but realize folks in the Ethereum community strongly advocate Solo Staking over trusting another third party.

Further, what I am stating is that the Ethereum Receive Address -- not the actual nodes -- should have the respective transactions recorded against it. It should be displayed within the transaction history for the wallet. To wit - the balance has changed (incremented). Why?

By your method of thinking, Quickbooks would not be responsible for reporting a significant debit against an account.

adrienlacombe commented 1 year ago

This is pure marketing, it doesn't translate well into technical realities, don't expect much when it comes to solo staking. You mention Quickbooks, is that accounting related? How do you use it? With Ledger Live?

jeffersonwarrior commented 1 year ago

@adrienlacombe-ledger Etherscan had no issue supporting the changes made to the Ethereum protocol to support the distinction between the various transactions.

I am amazed at your statement. You're stating that changes made to an account balance does not have to be tracked. This is primarily what we're dealing with in Crypto. On May 11, I had 1 Ethereum. On May 12, I have 2 Ethereum. By your logic, it really does not matter why.

Yes, Quickbooks is an accounting platform for Fiat-based systems. I was making a relatively normal analogy.

I do not understand as to why this concept isn't made clear by the various statements that I have made.

If there is an Ethereum Address managed by Ledger, it should display ALL transactions that affects the account balance. If the Ethereum Address has received Ethereum by any method, those methods should be displayed with the associated date and time history.

By your statement, it is "pure marketing" that an Ethereum Address has incremented. Go and take a look at Etherscan and even Ultrasound.Money again and tell me that 20 million stakers is "Pure Marketing".

It is not marketing. It is an important aspect of Ethereum and it is what makes it trustless.

adrienlacombe commented 1 year ago

I don't say it doesn't have to, I am saying sometimes it is hard to track and therefore requires development effort, that's all.

Solo staking is not pure marketing, I was referring to the statement "stake your Ethereum" now with Ledger; between solo staking, liquid staking, staking with a partner etc. the technical realities are very different.

jeffersonwarrior commented 1 year ago

@adrienlacombe-ledger Okay ... Fair points there.

Again - I labeled this as a [Feature] but I happen to think that it is an important one. If you would like, I will go so far as to reach out to my friends at EthStaker to chime in as well. I would think that they would agree that this is a feature needed within Ledger.

I do not intend to speak to development realities. I share your same concerns that what can be done in development vs. what the marketing people thing (lol magic? really?) are two different things.

I'm sorry if I came across strong -- but on my side, I have investors wondering what happened and I keep having to explain it. I have recommended Ledger to many, many people.

adrienlacombe commented 1 year ago

I couldn't agree more, I am a solo staker myself and you can find me on EthStaker Discord ;)

I will ping the Product Manager, highlighting the issue you are raising i.e. the tx history is not reflecting the ins and outs correctly in these scenarios.

jeffersonwarrior commented 1 year ago

Thank you very much.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

jeffersonwarrior commented 1 year ago

Hi - this is still an issue @adrienlacombe-ledger

adrienlacombe commented 1 year ago

Hi - this is still an issue @adrienlacombe-ledger

don't expect this to be fixed, well, at least not soon...

jeffersonwarrior commented 1 year ago

Okay ... I just don't want it to be autoclosed. It is an issue and - at the very least - it helps to raise awareness within the staking community.

adrienlacombe commented 1 year ago

Okay ... I just don't want it to be autoclosed. It is an issue and - at the very least - it helps to raise awareness within the staking community.

yes, np

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.