search

LedgerHQ / ledger-live

Mono-repository for packages related to Ledger Live and its JavaScript ecosystem.
MIT License
409 stars 302 forks source link

[Bug]: signature verification failed on BnB Beacon Chain #6336

Closed j75689 closed 4 months ago

j75689 commented 4 months ago

Impacted Library name

@ledgerhq/app-binance

Impacted Library version

1.1.7

Describe the bug

  1. Sign a tx with bnbcli/tbnbcli, and broadcast to the chain.

    ./bin/tbnbcli send --amount 10000001:BNB --to tbnb1v4wm6hexfkxgv7gu2va6adn2qg7udz3l73g9cc --from ld0 --chain-id Binance-Chain-Ganges --node https://data-seed-pre-0-s1.bnbchain.org:443 --ledger --trust-node --memo "abc"

  2. return signature verification failed

    image

  3. But try cmd with different text in --memo (e.g. "123"), that will succeed.

    image

Expected behavior

Attempting any of the --memo fields should succeed and no signature verification errors should occur.

Additional context

This problem never occurred when trying to send transactions without using ledger hardware for signing (using the local key of bnbcli/tbnbcli).

There may be inconsistencies in the encoding conversion on the ledger app (not 100% sure)

j75689 commented 4 months ago

resolved: https://github.com/bnb-chain/bnc-cosmos-sdk/pull/390