LedgerHQ / ledger-secure-sdk

https://ledgerhq.github.io/ledger-secure-sdk/
Apache License 2.0
20 stars 12 forks source link

Fix number of tag-value pairs displayed in a page for useCaseReviewStreamingContinueExt() #775

Open ajinkyaraj-23 opened 2 hours ago

ajinkyaraj-23 commented 2 hours ago

Description

When a skippable operation is started with useCaseReviewStreamingStart. when we provide the tag-value pairs to useCaseReviewStreamingContinueExt(), the page looks like follows: image The last pair of tag-value is being shadowed by the buttons.

Your environment

Steps to reproduce

Expected behaviour

The last pair should be pushed to next screen.

Actual behaviour

The last pairs is being shadowed by the buttons.

Logs

Proposed solution

I believe the calculation of number of pages is already there for other use cases, which could be used here.

tdejoigny-ledger commented 2 hours ago

good catch ty @ajinkyaraj-23 we are working on this cc: @nroggeman-ledger