search

LedgerHQ / ledger-wallet-chrome

Ledger Wallet Chrome application
http://www.ledgerwallet.com/apps/bitcoin
MIT License
161 stars 118 forks source link

Updated Stratis Extended Pub Key prefix #105

Closed bokobza closed 4 months ago

bokobza commented 6 years ago

The goal of this PR is to update the values of Stratis' Extended Public and Private Key prefixes in Ledger applications, in order for them to be in line with the ones from Stratis' code.

At the moment, Ledger applications have the following values for Stratis' Extended Public and Private Key prefixes: 0x0488C21E/76071454 for ExtPubKey 0x0488B2DD/87393172 for ExtPrivKey.

Stratis' BIP44 compatible wallet uses different values for these prefixes. The values in use are the same as Bitcoin: 0x0488B21E/76067358 for ExtPubKey 0x0488ADE4/76066276 for ExtPrivKey

See here: https://github.com/stratisproject/StratisBitcoinFullNode/blob/master/src/NBitcoin/Networks.cs#L425

bokobza commented 6 years ago

Linked: https://github.com/LedgerHQ/ledgerjs/pull/148 https://github.com/LedgerHQ/ledger-wallet-webtool/pull/25

bokobza commented 6 years ago

@gre What about this one and https://github.com/LedgerHQ/ledger-wallet-webtool/pull/25? Any chance of having someone look at it? Thanks

bokobza commented 6 years ago

@gre Now that the desktop app is out, I guess it's a good time to fix it in there?