LedgerHQ / ledger-wallet-chrome

Ledger Wallet Chrome application
http://www.ledgerwallet.com/apps/bitcoin
MIT License
161 stars 118 forks source link

FEATURE REQUST: Signing newly created addresses #69

Open ChristopherA opened 6 years ago

ChristopherA commented 6 years ago

This is based on a conversation with @gmaxwell yesterday:

There have in the past been a number of bugs in code in the creation of addresses, many of which are intermittent (one in 256 in one of his examples, in other the Electrum wallet would create a bad address if a block was received at exactly the same time). Thus as a general practice, he signs an address with its own private key and then verifies that its signature is valid. He says that bitcoind now does this internally every time it creates a new address.

I'd like confirm that the ledger bitcoin app does best practice this like bitcoind app does, i.e. double checking that the address is valid. Secondly, I'd like to see that this entire package (signed address) be sent to the chrome app, and that the chrome app also checks it. Finally, a small user interface icon next to an address can be clicked on to open a popup with the signed address text, allowing this signed address to be verified by other apps besides the chrome app (for instance, verifiable by the person sending me funds).