search

LedgerHQ / ledger-wallet-chrome

Ledger Wallet Chrome application
http://www.ledgerwallet.com/apps/bitcoin
MIT License
161 stars 118 forks source link

Improved traditional chinese translation #71

Open yurenju opened 6 years ago

yurenju commented 6 years ago

When I use ledger wallet chrome app I found some translation issues, most of the issues is some minor issues like inaccurate/incorrect translation which is fine, but there is one major issue: Language is totally wrong.

in original translation language.name is 中國 (China) which is wrong since China is a country not a language. the correct one is traditional chinese (繁體中文).

there are two different kind of chinese: Simplified Chinese and Traditional Chinese. Simplified Chinese is mainly used in China and Malaysia, and Traditional Chinese is mainly used is Taiwan.

So that is the reason I send this pull request, hope you guys can accept my pr 😺

yurenju commented 6 years ago

Any update?

yurenju commented 6 years ago

@pollastri-pierre not sure if my contributing way is correct or not, any suggestion?

LuPoYi commented 6 years ago

I also want to correct traditional chinese, but you already did, and could you also fix coin name part like this:

# %s is replaced by the coin name (i.e. bitcoin, litecoin)
common.errors.invalid_receiver_address=收件者的比特幣位址不正確。
wallet.send.common.send_bitcoins=發送比特幣
=>
common.errors.invalid_receiver_address=收件者的 %s 位址不正確。
wallet.send.common.send_bitcoins=發送%s

It's so weird that there are '發送比特幣' when I try to send Dash.