LedgerHQ / ledger-wallet-ripple

MIT License
65 stars 23 forks source link

Add trust line for Ripple Wallet #46

Closed ITTrooper closed 6 years ago

ITTrooper commented 6 years ago

Hi there It would be great if there was the possibility to add a trust line and new tokens to the wallet. This due to the fact that new tokens get on the XRP ledger (e.g. www.allvor.org).

Regards, I.

histteacher commented 6 years ago

Try this fix..

https://github.com/WietseWind/xrp-trustline-set-commandline

ITTrooper commented 6 years ago

@histteacher It took me some time, but I finally made it and got my ALVs. THANKS A LOT, you made my day!!! 🥇 👍

sCLARKware commented 6 years ago

ITTrooper, a few quick questions if you don't mind?

  1. After you finished, is there any way to see ALV in the Ledger Wallet Ripple desktop app, or only on an explorer like bithomp.com?
  2. You said it took some time... did you have issues with the code, or just the setup?
  3. Did you set the trust flag back to "0"? I'm not exactly sure if there are any repercussions if we leave the trust active.

Thanks so much!

ITTrooper commented 6 years ago
  1. I can only 'see' the coins on bithomp.com, not in the Ledger Wallet (unfortunately)
  2. Just the setup. Getting rid of all Java-classes and so on wasn't that easy, because I'm not very familiar with that.
  3. I don't know either if it should be set back to 0 or not. If you have any further information about that, please let me know. Thanks!

I hope my anwers did help you Regards

histteacher commented 6 years ago

Hi all.

Ledger wallet has not been updated to validate or read ALV. The ledger contains all value records. The ALV are there.

Where you set the trust to 10,000,000...just change that to 0. Be safe, close the trust. This essentially closes the trust. Run the process from the readme again.

As for the edits, if you are on a Microsoft PC, you can download Visual Studio Code (https://code.visualstudio.com/). Make sure the contents of GitHub have been unzipped to your "Windows/System32" folder. Open using the VS Code editor and make the edits based off of the directions. (Make sure you delete the files you have added!!! Clear your trash; shred anything with passcodes!)

IMPORTANT! --Repetitive Once you have run the file with your Ledger, gone to the ALV website to apply/receive the tokens, and verified receipt on bithomp.com, you should set the trust to zero, run it again following the readme directions from the zip, confirm again on bithomp that the trust is set to zero, and delete the all files. Shred them if you can. make sure all data and trash that may have potentially held your passcode(s) are gone!

ITTrooper commented 6 years ago

Sorry I don't get everything I have to do.

  1. I have to edit offline-with-mnemonic.js (value : "0"). After I let it run again.
  2. What is this all about visualstudio and what files do I have to delete?
  3. Where on bithomp can I see the trust?
histteacher commented 6 years ago

My apologies. There are a couple of steps for the checking via bithomp that the trust is set back to zero. I'm going to answer your three points as you have them listed. You can skip to #3 regarding checking the trust status. Hopefully this is less confusing.

1) ---- Setting Trust to Zero ----(this is optional and can always be reopened)...sounds like you did this correctly.

const Transaction = { TransactionType: 'TrustSet', Flags: 131072, // tfSetNoRipple Account: WalletAddress, LimitAmount: { currency : "ALV", issuer : "raEQc5krJ2rUXyi6fgmUAf63oAXmF7p6jp", value : "0" }, Fee: 15, LastLedgerSequence: null }

2) VisualStudio is what I use to edit the .js files. However, you could use whatever works best for you.

3) Seeing the trust...

  1. Enter you acct into bithomp
  2. Find your transaction ID for when you closed the trust...will say "Trustline" and near the ranked number it should say #2. Click on the Transaction ID, copy it.
  3. Go to Ripple's XRP Charts to pull the transaction from the ledger. Paste the txn ID from Bithomp and click Go.
    Ripple's XRP Charts: https://xrpcharts.ripple.com/#/transactions Should Read:
       DESCRIPTION:

This is a TrustSet transaction. It establishes 0 as the maximum amount of ALV from raEQc5krJ2rUXyi6fgmUAf63oAXmF7p6jp that rxxxxx(your_acct)xxxxxx is willing to hold. The transaction's sequence number is 2

I hope that helps.

ITTrooper commented 6 years ago

There's another parameter that has to be set, then it works let AccountSequence = (+1)

Great I made it! Thank you very much for your patience and support! 😃 👍

cious1 commented 6 years ago

Are IOUs and trustlines a planned added feature in the future for the ledger ripple software? Thank you for your support and time!

allencatt commented 6 years ago

found this thread while googling the subject. Unfortunately Im super non technical. my daughter has to turn my computer on for me. Is there a non tech way to retrieve the allvor waiting for me? I have been trying since mid April. Im a long term xrp holder and store my coins on the nano s. Any help at all would be greatly appreciated

histteacher commented 6 years ago

Hi. Wieste Wind is the developer. He put together a YouTube video to help. This is likely the least technical in creating the trust through your ledger.

I am not certain the recent updates by Ledger affect this process.

Here is the video: https://youtu.be/U_bDHgZ0wuc

Sincerely.

Get Outlook for iOShttps://aka.ms/o0ukef


From: allencatt notifications@github.com Sent: Monday, July 30, 2018 12:33 AM To: LedgerHQ/ledger-wallet-ripple Cc: histteacher; Mention Subject: Re: [LedgerHQ/ledger-wallet-ripple] Add trust line for Ripple Wallet (#46)

found this thread while googling the subject. Unfortunately Im super non technical. my daughter has to turn my computer on for me. Is there a non tech way to retrieve the allvor waiting for me? I have been trying since mid April. Im a long term xrp holder and store my coins on the nano s. Any help at all would be greatly appreciated

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLedgerHQ%2Fledger-wallet-ripple%2Fissues%2F46%23issuecomment-408707473&data=02%7C01%7C%7C9dd929d77f594462154d08d5f59ae3b4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636684967942664267&sdata=Twan3gubTEMDBKMjrKhq%2BAYPXmdykvhrQKC6eKaOjc8%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAkdHcOGqzSWz-6X-7sUA9lOA4S0zM1bEks5uLioZgaJpZM4TKtW3&data=02%7C01%7C%7C9dd929d77f594462154d08d5f59ae3b4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636684967942664267&sdata=7scEdzNupjPKk0epe2Lyz6dcbN97RtgSXE4a9rhs2EU%3D&reserved=0.

allencatt commented 6 years ago

Thanks for all your help. Im still scared out of my mind that i will really mess this up.

Allencatt1

On Jul 30, 2018, at 5:16 AM, histteacher notifications@github.com wrote:

Hi. Wieste Wind is the developer. He put together a YouTube video to help. This is likely the least technical in creating the trust through your ledger.

I am not certain the recent updates by Ledger affect this process.

Here is the video: https://youtu.be/U_bDHgZ0wuc

Sincerely.

Get Outlook for iOShttps://aka.ms/o0ukef


From: allencatt notifications@github.com Sent: Monday, July 30, 2018 12:33 AM To: LedgerHQ/ledger-wallet-ripple Cc: histteacher; Mention Subject: Re: [LedgerHQ/ledger-wallet-ripple] Add trust line for Ripple Wallet (#46)

found this thread while googling the subject. Unfortunately Im super non technical. my daughter has to turn my computer on for me. Is there a non tech way to retrieve the allvor waiting for me? I have been trying since mid April. Im a long term xrp holder and store my coins on the nano s. Any help at all would be greatly appreciated

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLedgerHQ%2Fledger-wallet-ripple%2Fissues%2F46%23issuecomment-408707473&data=02%7C01%7C%7C9dd929d77f594462154d08d5f59ae3b4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636684967942664267&sdata=Twan3gubTEMDBKMjrKhq%2BAYPXmdykvhrQKC6eKaOjc8%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAkdHcOGqzSWz-6X-7sUA9lOA4S0zM1bEks5uLioZgaJpZM4TKtW3&data=02%7C01%7C%7C9dd929d77f594462154d08d5f59ae3b4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636684967942664267&sdata=7scEdzNupjPKk0epe2Lyz6dcbN97RtgSXE4a9rhs2EU%3D&reserved=0. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

histteacher commented 6 years ago

I was too when I first tried it. :) Wieste is a trusted developer within the XRP community.

Best.

Get Outlook for iOShttps://aka.ms/o0ukef


From: allencatt notifications@github.com Sent: Monday, July 30, 2018 3:32 PM To: LedgerHQ/ledger-wallet-ripple Cc: histteacher; Mention Subject: Re: [LedgerHQ/ledger-wallet-ripple] Add trust line for Ripple Wallet (#46)

Thanks for all your help. Im still scared out of my mind that i will really mess this up.

Allencatt1

On Jul 30, 2018, at 5:16 AM, histteacher notifications@github.com wrote:

Hi. Wieste Wind is the developer. He put together a YouTube video to help. This is likely the least technical in creating the trust through your ledger.

I am not certain the recent updates by Ledger affect this process.

Here is the video: https://youtu.be/U_bDHgZ0wuc

Sincerely.

Get Outlook for iOShttps://aka.ms/o0ukef


From: allencatt notifications@github.com Sent: Monday, July 30, 2018 12:33 AM To: LedgerHQ/ledger-wallet-ripple Cc: histteacher; Mention Subject: Re: [LedgerHQ/ledger-wallet-ripple] Add trust line for Ripple Wallet (#46)

found this thread while googling the subject. Unfortunately Im super non technical. my daughter has to turn my computer on for me. Is there a non tech way to retrieve the allvor waiting for me? I have been trying since mid April. Im a long term xrp holder and store my coins on the nano s. Any help at all would be greatly appreciated

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLedgerHQ%2Fledger-wallet-ripple%2Fissues%2F46%23issuecomment-408707473&data=02%7C01%7C%7C9dd929d77f594462154d08d5f59ae3b4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636684967942664267&sdata=Twan3gubTEMDBKMjrKhq%2BAYPXmdykvhrQKC6eKaOjc8%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAkdHcOGqzSWz-6X-7sUA9lOA4S0zM1bEks5uLioZgaJpZM4TKtW3&data=02%7C01%7C%7C9dd929d77f594462154d08d5f59ae3b4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636684967942664267&sdata=7scEdzNupjPKk0epe2Lyz6dcbN97RtgSXE4a9rhs2EU%3D&reserved=0. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLedgerHQ%2Fledger-wallet-ripple%2Fissues%2F46%23issuecomment-408847283&data=02%7C01%7C%7C640c2005777a4cabf34708d5f61875d0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636685507264732916&sdata=5e0MRdc7jNXBKE6B4%2Fjx0TbxD7aIbyG5qbfpJ4hnYLc%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAkdHcDIUt053XIu_tFlMSom_ewGSxkOJks5uLvzEgaJpZM4TKtW3&data=02%7C01%7C%7C640c2005777a4cabf34708d5f61875d0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636685507264732916&sdata=XXpQlcajWWVB%2F0cr3UrEgVt%2FZpISLTXxYq6PnqjX1C0%3D&reserved=0.