LedgerHQ / ledgerctl

A library to control Ledger devices
MIT License
40 stars 20 forks source link

ledgerwallet broken due to removal of "iterateints" from construct.core #17

Closed cybern0id closed 3 years ago

cybern0id commented 3 years ago

Whilst trying the Ledger satstack manual setup, using ./getdescriptor --scheme native_segwit --chain main --account 3 as described in the satstack github readme the following error is thrown:

 :~$./getdescriptor --scheme native_segwit --chain main --account 3
Traceback (most recent call last):
  File "/home/user/sources/satstack/scripts/./getdescriptor", line 11, in <module>
    from ledgerwallet.client import LedgerClient
  File "/home/user/sources/satstack/scripts/venv/lib/python3.9/site-packages/ledgerwallet/client.py", line 29, in <module>
    from ledgerwallet.manifest import AppManifest
  File "/home/user/sources/satstack/scripts/venv/lib/python3.9/site-packages/ledgerwallet/manifest.py", line 10, in <module>
    from ledgerwallet import params
  File "/home/user/sources/satstack/scripts/venv/lib/python3.9/site-packages/ledgerwallet/params.py", line 20, in <module>
    from construct.core import (
ImportError: cannot import name 'iterateints' from 'construct.core' (/home/user/sources/satstack/scripts/venv/lib/python3.9/site-packages/construct/core.py)

Probably due to the following change in construct:

https://github.com/construct/construct/commit/8915512f53552b1493afdbce5bbf8bb6f2aa4411#diff-c220abf06c61d7360f8e248c82062a25c2b685224226a6c5d769971cd1551fb8

and the recent release of construct version 2.10.63

Reverting to construct version 2.10.61 restores functionality.

kevinqualters commented 3 years ago

@jibeee can you tag and publish https://github.com/LedgerHQ/ledgerctl/pull/18 so that the version on pip isn't busted?