Closed jamespic closed 6 years ago
@jamespic good point! can you send a PR ? thanks
Yep, can do.
I couldn't find the tests for web3-subprovider
. What approach should I take to testing?
we don't have much test yet for web3-subprovider but you can test if it works with the dapp starter. we will try to improve tests later (but mainly we are waiting to have a ledger simulator so we can headless-ly run tests)
I think you can send a PR and we'll try it out too
web3-subprovider
only allows derivations that begin with44'/60'
or44'/61'
. Adding44'/1'
would enable testnet accounts to be derived appropriately.