search

LedgerHQ / ledgerjs

⛔️ MOVED to monorepo "ledger-live"
https://github.com/LedgerHQ/ledger-live
Apache License 2.0
574 stars 377 forks source link

Support Testnet derivations in web3-subprovider #144

Closed jamespic closed 6 years ago

jamespic commented 6 years ago

web3-subprovider only allows derivations that begin with 44'/60' or 44'/61'. Adding 44'/1' would enable testnet accounts to be derived appropriately.

gre commented 6 years ago

@jamespic good point! can you send a PR ? thanks

jamespic commented 6 years ago

Yep, can do.

I couldn't find the tests for web3-subprovider. What approach should I take to testing?

gre commented 6 years ago

we don't have much test yet for web3-subprovider but you can test if it works with the dapp starter. we will try to improve tests later (but mainly we are waiting to have a ledger simulator so we can headless-ly run tests)

I think you can send a PR and we'll try it out too