search

LedgerHQ / ledgerjs

⛔️ MOVED to monorepo "ledger-live"
https://github.com/LedgerHQ/ledger-live
Apache License 2.0
572 stars 375 forks source link

Support 'OfferCreate' transaction type for packages/hw-app-xrp #216

Closed whaus7 closed 6 years ago

whaus7 commented 6 years ago

Right now SignTransaction only support 'Payment' transaction types for XRP. I started working on this but I suppose I should see if anyone is already working on this.

This is definitely out of my comfort zone so if anyone has any docs they could point me to so I could understand where to even begin

https://developers.ripple.com/transaction-types.html

gre commented 6 years ago

Thanks for the issue. https://github.com/LedgerHQ/ledger-app-xrp should be the place to feature request this since it's not yet a thing in the app. Once that, we can modify the correct code on the js library.

whaus7 commented 6 years ago

Yep sorry. Already posted over there. Meant to close this!