LedgerHQ / ledgerjs

⛔️ MOVED to monorepo "ledger-live"
https://github.com/LedgerHQ/ledger-live
Apache License 2.0
574 stars 379 forks source link

Support 'TrustSet' transaction type for packages/hw-app-xrp #217

Closed ghost closed 5 years ago

ghost commented 5 years ago

The Ledger XRP app currently supports nothing but payment transactions. Which promotes insecure practices such as entering ones mnemonic words in third-party tools, in order to sign trust line transactions.

In other words, Ledger Nano S/Nano/Blue users currently have no secure way to participate in XRP ledger airdrops and trade on the XRP ledger's decentralized exchange.

References: https://developers.ripple.com/transaction-types.html https://developers.ripple.com/trustset.html

gre commented 5 years ago

Thanks for the issue. https://github.com/LedgerHQ/ledger-app-xrp should be the place to feature request this since it's not yet a thing in the app. Once that, we can add the apdu calls on the js library.