LedgerHQ / ledgerjs

⛔️ MOVED to monorepo "ledger-live"
https://github.com/LedgerHQ/ledger-live
Apache License 2.0
575 stars 377 forks source link

Fix wrong bytestring parsing in NFT informations + missing awaits #762

Closed lambertkevin closed 2 years ago

lambertkevin commented 2 years ago

Spec for the bytestring parsing: https://ledgerhq.atlassian.net/wiki/spaces/WALLETCO/pages/3269984297/NFT-1+NFT+Backend+design#NFT-Metadata-BLOB

codecov[bot] commented 2 years ago

Codecov Report

Merging #762 (4752ec5) into master (ae240fb) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #762   +/-   ##
=======================================
  Coverage   43.56%   43.56%           
=======================================
  Files          81       81           
  Lines        4823     4823           
  Branches      791      791           
=======================================
  Hits         2101     2101           
  Misses       2705     2705           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae240fb...4752ec5. Read the comment docs.

porenes commented 2 years ago

@lambertkevin can you add in the merge commit a ticket number 🙏