search

LedgerHQ / ledgerjs

⛔️ MOVED to monorepo "ledger-live"
https://github.com/LedgerHQ/ledger-live
Apache License 2.0
574 stars 382 forks source link

LL 8968 - Add strict mode to prevent blind signing in live #780

Closed lambertkevin closed 2 years ago

lambertkevin commented 2 years ago

This PR add the notion of strictMode for the Eth class in order to throw errors on specific cases related to transaction resolution.

LL-8968

codecov[bot] commented 2 years ago

Codecov Report

Merging #780 (9a7effb) into master (39ff487) will increase coverage by 0.01%. The diff coverage is 29.72%.

:exclamation: Current head 9a7effb differs from pull request most recent head 0ec2246. Consider uploading reports for the commit 0ec2246 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   43.51%   43.53%   +0.01%     
==========================================
  Files          81       81              
  Lines        4883     4893      +10     
  Branches      859      860       +1     
==========================================
+ Hits         2125     2130       +5     
- Misses       2744     2749       +5     
  Partials       14       14
Impacted Files Coverage Δ
packages/hw-app-eth/src/Eth.ts 77.85% <29.72%> (-0.63%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39ff487...0ec2246. Read the comment docs.