LedgerHQ / ledgerjs

⛔️ MOVED to monorepo "ledger-live"
https://github.com/LedgerHQ/ledger-live
Apache License 2.0
575 stars 377 forks source link

Fixes README typos #782

Closed jritchie-nullable closed 2 years ago

jritchie-nullable commented 2 years ago
jritchie-nullable commented 2 years ago

https://github.com/LedgerHQ/ledgerjs/issues/781

codecov[bot] commented 2 years ago

Codecov Report

Merging #782 (d3736e1) into master (39ff487) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   43.51%   43.51%           
=======================================
  Files          81       81           
  Lines        4883     4883           
  Branches      859      859           
=======================================
  Hits         2125     2125           
  Misses       2744     2744           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39ff487...d3736e1. Read the comment docs.

gre commented 2 years ago

the doc is generated from the code, the typo are in comment of the code.

gre commented 2 years ago

if you run yarn doc it will regenerate it. but the root issue is at https://github.com/LedgerHQ/ledgerjs/blob/d3736e136b55100ec3c6464253224eb8013fd34a/packages/hw-app-algorand/src/Algorand.ts#L35

gre commented 2 years ago

I'll take it