LedgerHQ / ledgerjs

⛔️ MOVED to monorepo "ledger-live"
https://github.com/LedgerHQ/ledger-live
Apache License 2.0
574 stars 382 forks source link

LL-8968 throw error of provideNFTInformation #783

Closed gre closed 2 years ago

gre commented 2 years ago

this implement the minimal part of LL-8968 that is important for the NFT feature.

codecov[bot] commented 2 years ago

Codecov Report

Merging #783 (058afac) into master (39ff487) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   43.51%   43.53%   +0.01%     
==========================================
  Files          81       81              
  Lines        4883     4881       -2     
  Branches      859      858       -1     
==========================================
  Hits         2125     2125              
+ Misses       2744     2742       -2     
  Partials       14       14              
Impacted Files Coverage Δ
packages/hw-app-eth/src/Eth.ts 78.82% <ø> (+0.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39ff487...058afac. Read the comment docs.

gre commented 2 years ago

confirmed to work as expected. (manual test)