elbywan commented 2 years ago

Package @ledgerhq/hw-app-helium added with this PR has a missing dependency.

@helium/proto itself is technically a dependency of other @helium/… packages but it is not good practice to directly import transitive dependencies like this (and the build will fail with pnpm since it is stricter than yarn).

src/Helium.ts(12,19): error TS2307: Cannot find module '@helium/proto' or its corresponding type declarations.

codecov[bot] commented 2 years ago

Codecov Report

Merging #787 (7afc84f) into master (fe8a810) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   45.17%   45.17%           
=======================================
  Files          83       83           
  Lines        5052     5052           
  Branches      893      893           
=======================================
  Hits         2282     2282           
  Misses       2756     2756           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe8a810...7afc84f. Read the comment docs.

gre commented 2 years ago

it's curious why our CI didn't see it. thanks.

LedgerHQ / ledgerjs

chore: add missing @helium/proto dependency #787

Codecov Report