search

LedgerHQ / ledgerjs

⛔️ MOVED to monorepo "ledger-live"
https://github.com/LedgerHQ/ledger-live
Apache License 2.0
575 stars 377 forks source link

20220309 CAL update #808

Closed adrienlacombe closed 2 years ago

adrienlacombe commented 2 years ago

I think you would need to do a "release" of the cryptoassets package, if that makes sense and then include this new version everywhere. I let @gre confirm. Thank you :pray:

codecov[bot] commented 2 years ago

Codecov Report

Merging #808 (2665cb1) into master (5231dbe) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   45.59%   45.59%           
=======================================
  Files          82       82           
  Lines        5005     5005           
  Branches      891      891           
=======================================
  Hits         2282     2282           
  Misses       2527     2527           
  Partials      196      196

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5231dbe...2665cb1. Read the comment docs.

gre commented 2 years ago

ledgerjs crypto list = if it pass the ci it's good to merge.

now for the Ledger Live side: the ledgerjs package just was released a few days ago with previous iteration and it was validated on LLD/LLM so it just happened to get merged, so i guess this will need to go in the next future train we have on this stack

adrienlacombe commented 2 years ago

yes np, thank you @gre :)