LedgerHQ / nanos-secure-sdk

Secure (ST31) SDK for Ledger Nano S
Apache License 2.0
98 stars 53 forks source link

pathnames for source dirs cannot contain `.c` inside even not at the end #16

Closed rudi-cilibrasi closed 1 year ago

rudi-cilibrasi commented 6 years ago

this means we cannot compile apps that use a directory structure like:

src/github.com/should_work.c
src/github.com/should_work.h

where should_work.h is empty and should_work.c simply tries to include should_work.h. An error will be generated when trying to build:

make: *** No rule to make target 'om/should_work.h', needed by 'obj/should_work.o'.  Stop.

It is because of a bad sed regexp, PR forthcoming

fbeutin-ledger commented 1 year ago

Fixed in latest unified SDK This behavior is confirmed working, tested with

$> ll src/toto.com/
total 16
drwxrwxr-x 2 francois francois 4096 Mar 28 17:01 ./
drwxrwxr-x 9 francois francois 4096 Mar 28 17:00 ../
-rw-rw-r-- 1 francois francois  345 Mar 28 17:02 file.c
-rw-rw-r-- 1 francois francois   41 Mar 28 17:02 file.h