search

LedgerHQ / rust-app-password-manager

Apache License 2.0
16 stars 7 forks source link

Update app #2

Open pscott opened 3 years ago

pscott commented 3 years ago

Some PRs got merged on the ledger-nanos-sdk, so an update was required here :)

I used ".into()" for StatusWords, but we could change that to "Reply::from(..)" if you'd like (though it's a bit more verbose imho).

kingofpayne commented 3 years ago

I think most of the changes have been integrated in master now. Regarding .into calls for status words, it has been made optional in the SDK as it was looking to much verbose (this is why this PR has not been merged in the first place).

We may keep commits 85e437c and 0451de1 as it. We can apply changes of 9536151 but it requires to be updated as code in master has slightly changed for this method. Can you update the branch to resolve all conflicts ?