LedgerHQ / satstack

Bitcoin full node with Ledger Live
BSD 2-Clause "Simplified" License
159 stars 32 forks source link

Improve speed when importing descriptors (startup time) and some smaller changes #94

Closed ziggie1984 closed 1 year ago

ziggie1984 commented 1 year ago

This PR is the first one of my journey improving this tool, to make it more useable and finally integrating it to the raspiblitz. This PR makes 3 things which are separated by their own commits, making them easy to review and getting them merged hopefully fast.

  1. It changes the importing scheme of the descriptors. The old logic was to import every descriptor separately which leads to several rescan along the way. Doing this in one move lets us only load the descriptor once making the rescan time unrelated to the amount of descriptors which are loaded in

  2. It adds a new Load wallet failure message which was maybe introduced along the way also catching an error where the wallet is already loaded and we do not recognize it.

  3. Third thing is a small cli flag to skip the circulation check, makes testing faster because it takes to long for testing it makes life easier.

This fixes several issues one of them is #77