LedgerHQ / wallet-connect-live-app

https://wallet-connect-live-app.vercel.app/
7 stars 6 forks source link

Incorrect AppMetaData info for WC connection #122

Closed gvoltr closed 11 months ago

gvoltr commented 1 year ago

Ledger live android app returns incorrect info in AppMetaData for Wallet Connect 2 connection.

Here is example of ApprovedSession object that WC returns for Ledger Live app connection. The url and icon is incorrect in AppMetaData

ApprovedSession(topic=be8afa1172f04ede06de688d29928a934c01c6d508b21fbca3ecfd6b1e6f4798, metaData=AppMetaData(name=Ledger Wallet, description=Ledger Live Wallet with WalletConnect, url=https://walletconnect.com/, icons=[https://avatars.githubusercontent.com/u/37784886], redirect=null, verifyUrl=null), namespaces={eip155=Session(chains=[eip155:1, eip155:137], accounts=[eip155:1:0x42740D63644Db0A8Dd8D369d2Cb1316d97494de6, eip155:137:0x42740D63644Db0A8Dd8D369d2Cb1316d97494de6], methods=[eth_sendTransaction, personal_sign], events=[])}, accounts=[eip155:1:0x42740D63644Db0A8Dd8D369d2Cb1316d97494de6, eip155:137:0x42740D63644Db0A8Dd8D369d2Cb1316d97494de6])
github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.