Closed Justkant closed 7 months ago
Sentry errors are correctly sent, tested using this branch https://github.com/LedgerHQ/wallet-connect-live-app/pull/149 which has a button that throws an unhandled error.
Error ended up here: https://ledger.sentry.io/releases/27afd3f447d22054760e309e828aa820a6fefe2b/?project=4505556204257280
New bug noticed, on LLD:
Nothing will happen when you press enter
New bug noticed, on LLD:
- Click on "Scan QR Code"
- Don't do anything with it
- Try to input the connection string instead
Nothing will happen when you press enter
Well I hard a hard time reproducing it until I figured out what happens. The link (that's input in the connection string) was expired, when it is, it closes the QR code video feed and reset the input with no error, but that's it. With a proper connection string it works fine.
Nice Job Guys ! π
π Description
WIP Still some improvements to do:
ApplicationDisabled
support again (@Justkant on it)@Wozacosta on itcommit: https://github.com/LedgerHQ/wallet-connect-live-app/pull/144/commits/e4b8bfcde71cc4f05637f80fe7f40e1d2cf42b7e and https://github.com/LedgerHQ/wallet-connect-live-app/pull/144/commits/31ec443c3bd8b69499440421468588b784eb8346)More details here
## import.meta.env tsconfig `module` option set to `ESNext` https://www.totaltypescript.com/tsconfig-cheat-sheet https://github.com/LedgerHQ/wallet-connect-live-app/pull/144/commits/4fb6825fb2d262581929e03de553d6c312327de2 ## Startup props errors Those errors were due to the fact that we used a `TransitionGroup` element which children were not Transitions, this components tried to pass transition-specifics props to non-transition components. Commit : https://github.com/LedgerHQ/wallet-connect-live-app/pull/144/commits/af9927a062bf6a3773292a10947aa40ced6cc430 ## search tabs error ``` src/components/screens/Home.tsx:133:9 - error TS2322: Type 'import("/Users/samy.rabah-montarou/Code/wallet-connect-live-app/src/shared/navigation").TabsIndexes | undefined' is not assignable to type 'number'. Type 'undefined' is not assignable to type 'number'. 133 activeTabIndex={search.tab} ~~~~~~~~~~~~~~ ``` fixed in commit : https://github.com/LedgerHQ/wallet-connect-live-app/pull/144/commits/a712b959eaed3f25086da062cb3d977cf9304b8a@Wozacosta on itcommit: https://github.com/LedgerHQ/wallet-connect-live-app/pull/144/commits/ba53fdf63ebb5b19a43984f5dd822f48fe717968)@Wozacosta on itcommit: https://github.com/LedgerHQ/wallet-connect-live-app/pull/144/commits/ba53fdf63ebb5b19a43984f5dd822f48fe717968)More details here
``` VITE_WALLETCONNECT_PROJECT_ID VITE_SENTRY_DNS VITE_PUBLIC_SENTRY_DSN VITE_APP_VERSION VITE_PUBLIC_SEGMENT_API_KEY_DESKTOP VITE_PUBLIC_SEGMENT_API_KEY_MOBILE ```useProposal
could be reworked (reworked partially at the moment)β Context
πΈ Demo
π Expectations to reach
Pull Requests must pass the CI and be internally validated in order to be merged.