search

LedgerHQ / wallet-connect-live-app

https://wallet-connect-live-app.vercel.app/
7 stars 6 forks source link

Wallet Connect v1 does not pop up signMessage modal for eth_signTypedData #61

Closed ericpan0207 closed 1 year ago

ericpan0207 commented 1 year ago

There's already a report here: https://github.com/LedgerHQ/ledger-live/issues/2870

Some more details that are specific to my case: Using Ledger-nano-x and Ledger Live Desktop App.

I wallet connect, using wallet connect v1, to my dapp that uses gnosis safe sdk to sign and execute transactions on chain. When I call gnosis sdk to signTransaction using the eth_signTypedData signing method, there is no popup sign message modal on ledger live desktop for me to be actually sign on my ledger. When I use eth_sign signing method, the popup signing modal does pop up and I'm able to sign on my ledger

There's also another user that did more detailed testing than me that's posted their information on the official discord: https://discord.com/channels/885256081289379850/1081199909904056473/1081199909904056473

adrienlacombe commented 1 year ago

@ericpan0207 this is fixed

mcayuelas-ledger commented 1 year ago

As it has been fixed and V1 isn't supported anymore by us.

Closing the issue