LedgerHQ / wallet-connect-live-app

https://wallet-connect-live-app.vercel.app/
7 stars 6 forks source link

In dApps using Wallet Connect v2, the signatures don't get back to the dApp. #65

Closed theotniel closed 1 year ago

theotniel commented 1 year ago

We have tested with some dApps referenced in https://github.com/WalletConnect/web-examples and while the account connection works great, it seems that somehow the signed messages never get back to the apps:

Here are the steps to reproduce:

  1. Go to https://react-app.walletconnect.com/
  2. Select Ethereum and/or Polygon
  3. Click the Connect button
  4. Select Ledger -> LLD opens
  5. In LLD select ledger accounts to be connected
  6. In LLD click Connect
  7. On the waletconnect app webpage a list of possible methods appears
  8. Click personal_sign
  9. In LLD - Sign message modal appears -> click Continue
  10. On the ledger device confirm Sign message

The expected result is to see the signature and validation status in the waletconnect web app (as in the attached image), but the page just waits forever.

Screenshot 2023-05-11 at 16 33 31

For reference:

More context on discord.

PaulUD commented 1 year ago

eth_signTransaction and eth_sendTransaction are being processed on chain by the sample React dApp but unfortunately as pointed out the other 3 transaction types are failing.

mcayuelas-ledger commented 1 year ago

This problem has been solved recently. Can you confirm?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.