Closed nickcjohnston closed 8 years ago
Thanks - really appreciated.
I will go through and verify everything and merge it in :)
Aha - you can spot that I don't typically "do" python and you do... thanks!
Thanks for the merge :) (also never underestimate the power of a good static analyzer)
On Mon, Oct 5, 2015 at 9:17 AM leE notifications@github.com wrote:
Aha - you can spot that I don't typically "do" python and you do... thanks!
— Reply to this email directly or view it on GitHub https://github.com/LeeBrotherston/tls-fingerprinting/pull/9#issuecomment-145524150 .
Removed some trailing semi-colons from statements, added some aug assignments and (perhaps the only one that matters), noticed that a few times ext_len was calculated but not included in the print statement. To my knowledge, the length was supposed to be included for extension parsing reasons.