search

LeeCampbell / HdrHistogram.NET

Port of the HdrHistorgram to .NET/C#
Other
18 stars 3 forks source link

Sign the main assembly and add the passwordless key to this repo #71

Closed buybackoff closed 7 years ago

buybackoff commented 7 years ago

The best practice followed by major projects currently is to keep a key in a repo and sign assemblies with it.

It would be nice to have an updated NuGet package soon.

Thanks!

buybackoff commented 7 years ago

It looks like the NuGet package is actually signed but there is no indication of this fact neither in this repo nor on NuGet description page. I used to have a local build and the dependency broke after I signed my assemblies that used HdrHistogram.NET. And #68 is still open so I was confused.

LeeCampbell commented 7 years ago

Sorry for the confusion, I really should delete this repo as it was moved to https://github.com/HdrHistogram/HdrHistogram.NET/ some time ago. There you will see the key is in the repo and that is where the Nuget files are produced from.

buybackoff commented 7 years ago

I see, thanks! When I first started using the library, I remember you mentioned somewhere that the upstream was not accepting updates and therefore you maintained your own fork. Then I didn't monitor updates.