search

LeeMingDe / pe

0 stars 0 forks source link

Using large numbers breaks the qty #2

Open LeeMingDe opened 3 years ago

LeeMingDe commented 3 years ago

Steps to reproduce:

  1. type in command edit recipe pancakes /ingredient:edit syrup /qty 9999999999999999999999999999999999999999999999999ml
  2. press enter

image.png

nus-se-bot commented 3 years ago

Team's Response

This is due to the use of double as the data type for quantities. Perhaps we should have indeed implemented limits for user input. However, it is unlikely that users will store ingredients that are heavier than the mass of the moon, so we are downgrading the severity to Low.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]