search

LeeVD / plasma-applet-net-bandwidth-monitor

Network bandwidth monitor for plasma using dbus
GNU General Public License v3.0
24 stars 4 forks source link

Missing Icons #3

Closed tazihad closed 1 year ago

tazihad commented 1 year ago

There are 3 missing icons. I am using Fedora 37 KDE.

Screenshot_20221229_074450

LeeVD commented 1 year ago

Thanks for letting me know. Not sure why but Github dropped the icons from the code in those 3 icon dropdown rows. Did you build from source or install via Plasma desktop widget section? I'm wondering if its an installed font pack issues.

luisbocanegra commented 1 year ago

Definitely a font issue, maybe you should add a note for the users to use a different font (e.g. a nerd font https://github.com/ryanoasis/nerd-fonts), in case they face this problem. Maybe you could include a custom stripped font with the plasmoid just for the glyphs? (taking license into account of course)

LeeVD commented 1 year ago

Note added Luis. I've done a little research and think the custom stripped font with the plasmoid just for the glyphs would be the best/simple solution. Working on the update.

LeeVD commented 1 year ago

I think I've fixed the icon missing in the dropdown issue. Tested on latest Fedora KDE edition with v0.1.1 widget and icons are present. Let me know if this is not the case.

Screenshot_20230115_180135

luisbocanegra commented 1 year ago

I have an idea, an option to manually set the upload/download text/icons that will be displayed in the widget :)

LeeVD commented 1 year ago

I think this should be doable, once I've fixed all the issues :) How much text space would you expect?

luisbocanegra commented 1 year ago

I think this should be doable, once I've fixed all the issues :) How much text space would you expect?

Hmm, probably stay the same? Or you meant how many characters should be allowed?

I don't know, a single character text should suffice? Could be more if you want, depending on how you handle the widget size/alignment and text size.

LeeVD commented 1 year ago

Custom icons makes sense, maybe if someone wanted a semicolon as a divider, so 2 or 3 characters length. If someone wanted a string of text i guess that would need to be managed some how, maybe limit the number characters and which characters are allowed? The widget 'should' expand to accommodate the text length but then again, I've seen the size not correctly fit the icons i have used. I'm guessing this is something to do with the icon reporting what size it should be incorrectly. Will look in to it, thanks.

luisbocanegra commented 1 year ago

Custom icons makes sense, maybe if someone wanted a semicolon as a divider, so 2 or 3 characters length. If someone wanted a string of text i guess that would need to be managed some how, maybe limit the number characters and which characters are allowed?

A 2-3 limit seems reasonable to me

The widget 'should' expand to accommodate the text length but then again, I've seen the size not correctly fit the icons i have used. I'm guessing this is something to do with the icon reporting what size it should be incorrectly.

Yeah that's a very common issue with some glyphs in patched fonts like nerd fonts so allowing an extra space in the text fields would make sense for those cases.

tazihad commented 1 year ago

Icons seems fixed in 0.2 version.