LeeWangyeol / kuda

Automatically exported from code.google.com/p/kuda
GNU General Public License v2.0
0 stars 0 forks source link

Rotator defaults to disabled and ignores a disable when rotate is called #91

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
We have decided to change the default behavior to enabled once constructed and 
have rotate respect a disabled state. The render listener will get added once 
rotate is called and removed once rotation is done.

Original issue reported on code.google.com by jpywt...@gmail.com on 18 Aug 2011 at 12:40

GoogleCodeExporter commented 8 years ago
Making the change to motion.js and testing

Original comment by jpywt...@gmail.com on 18 Aug 2011 at 12:41

GoogleCodeExporter commented 8 years ago
Changed motion.js to default to enabled. Change rotate to respect a disabled 
rotator. Samples that use the rotator test good and editor behavior tests good. 
Now an editor behavior can disable a rotator rotate event.

Original comment by jpywt...@gmail.com on 18 Aug 2011 at 5:01

GoogleCodeExporter commented 8 years ago
Tested fixed

Original comment by jpywt...@gmail.com on 18 Aug 2011 at 5:01

GoogleCodeExporter commented 8 years ago
Re-opening as there is a use case the worked missed. Discussed it with Erik and 
came up with a refactoring plan.

Original comment by jpywt...@gmail.com on 18 Aug 2011 at 6:31

GoogleCodeExporter commented 8 years ago
Refactored the rotator to be enabled by default still, but handle the direct 
setting velocity or acceleration through the setters. Each setter will check 
for enabled state and properly add or remove the render listener. Setting the 
angle also properly will rotate the rotator immediately.

Original comment by jpywt...@gmail.com on 18 Aug 2011 at 11:51

GoogleCodeExporter commented 8 years ago
Verified

Original comment by jpywt...@gmail.com on 8 Sep 2011 at 7:28