LeeWannacott / table-sort-js

HTML table sorting with no dependencies.
https://cdn.jsdelivr.net/npm/table-sort-js@latest/table-sort.js
MIT License
76 stars 26 forks source link

Browser ext: Handle table has <th> at start of each table row. #127

Closed LeeWannacott closed 7 months ago

LeeWannacott commented 9 months ago

Sort gets messed up if each table row has <th> at the start. Ops/sec doesn't infer numeric-sort check if its because of this, or some other reason.

LeeWannacott commented 7 months ago

Fixed for the most part in https://github.com/LeeWannacott/table-sort-js/releases/tag/v1.20.0

numeric-sort needs to handle currency and vanilla js ops has spans with the value in them; which isn't sorted.

Tests for this need to be written, I only manually tested this. This will most likely require rejigging testing not just writing the tests...