A web solution for anyone storing and maintaining their collections of trading cards. The application has full CRUD functionality, along with user authentication, and even a third party API integration for pricing cards. The application also allows for file uploading, for processing large volumes of cards.
Reviewer comments and suggestions go here. Each item should have at least one "kudos" and two suggestions for improvement
Problem Statement
1. Accurately describes project purpose 2. Is professional and free of typos, slang, etc. 3. Fully explains the problem and the solution 4. Is understandable by the average person
I was really impressed with the amount of thought that went into your project - you really spent a lot of time thinking about the little details. I am looking forward to seeing the final product as I do card collection too and have thought about creating an application for tracking.
Design Documentation
1. Navigation/flow through the application is logical and easy to use. 2. The order in which values are displayed are logical and easy to understand/use 3. The order in which the form fields entered are logical and easy to understand/use 4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens
One suggestion I have is to consider having a list on your home page that shows a list of your highest percentage increase in value cards as well as a list of your highest percentage decrease cards.
Data model/Database
1. Everything on the screens and problem statement/flow is represented in the model 2. There is at least one 1-to-many relationship. 3. The model represents good database design
Not set up yet - make sure to create a ERD diagram once you do as I believe it is very helpful for someone to understand your data
Code
1. Proper Maven project structure is used 2. a .gitignore file for IntelliJ Java projects has been implemented 3. There is not any redundant or copy/paste code in the JSPs or classes 4. Classes are appropriately-sized (no monster classes) Property files are used appropriately: no hard-coded values 5. Logging statements are used rather than System.out.println and printStackTrace. 6. There are appropriate unit tests/code coverages.
Code looks good - may want to consider using a more unique folder name than "java" for your root such as "com.enterpriseJava.Lee" as an example
Design/Code Review 1
Project: YuGiOh application
Developer: Lee
Reviewer: Joe A
2. Is professional and free of typos, slang, etc.
3. Fully explains the problem and the solution
4. Is understandable by the average person
2. The order in which values are displayed are logical and easy to understand/use
3. The order in which the form fields entered are logical and easy to understand/use
4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens
2. There is at least one 1-to-many relationship.
3. The model represents good database design
2. a .gitignore file for IntelliJ Java projects has been implemented
3. There is not any redundant or copy/paste code in the JSPs or classes
4. Classes are appropriately-sized (no monster classes)
Property files are used appropriately: no hard-coded values
5. Logging statements are used rather than System.out.println and printStackTrace.
6. There are appropriate unit tests/code coverages.