LeeYang2019 / Card-Database

A web solution for anyone storing and maintaining their collections of trading cards. The application has full CRUD functionality, along with user authentication, and even a third party API integration for pricing cards. The application also allows for file uploading, for processing large volumes of cards.
https://youtu.be/6cBaNtQ6cP8
4 stars 0 forks source link

Code Review 1 - Julie #3

Open cortezjl opened 5 years ago

cortezjl commented 5 years ago

Design/Code Review 1

Project:

Developer:

Reviewer:

Item Considerations Comments/Suggestions
Reviewer comments and suggestions go here. Each item should have at least one "kudos" and two suggestions for improvement
Problem Statement 1. Accurately describes project purpose
2. Is professional and free of typos, slang, etc.
3. Fully explains the problem and the solution
4. Is understandable by the average person
Good job explaining your project. It is good that you found something to create that you are passionate about.
Design Documentation 1. Navigation/flow through the application is logical and easy to use.
2. The order in which values are displayed are logical and easy to understand/use
3. The order in which the form fields entered are logical and easy to understand/use
4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens
Good job on the screen mock ups
Data model/Database 1. Everything on the screens and problem statement/flow is represented in the model
2. There is at least one 1-to-many relationship.
3. The model represents good database design
Code 1. Proper Maven project structure is used
2. a .gitignore file for IntelliJ Java projects has been implemented
3. There is not any redundant or copy/paste code in the JSPs or classes
4. Classes are appropriately-sized (no monster classes)
Property files are used appropriately: no hard-coded values
5. Logging statements are used rather than System.out.println and printStackTrace.
6. There are appropriate unit tests/code coverages.
It is a too early in the project for the code review.