Leechael / memcache-top

Automatically exported from code.google.com/p/memcache-top
0 stars 0 forks source link

Use of 'instances' is confusing, use 'hosts' #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Most scripts use the term host vs. instance. -h and --hosts flags would be
great.

Original issue reported on code.google.com by adam.ros...@gmail.com on 29 Oct 2009 at 12:05

GoogleCodeExporter commented 9 years ago
I'll take a look.  I wanted to review and see what's worth adding w/ 1.4.x 
anyways.

But it's not a defect.  :)  That works fine, you just don't like the shortcut.

Original comment by nicholas...@gmail.com on 29 Oct 2009 at 12:09

GoogleCodeExporter commented 9 years ago
Sorry I didn't categorize correctly. There doesn't seem to be a way for me to 
change
it. Thanks!

Original comment by adam.ros...@gmail.com on 29 Oct 2009 at 12:13

GoogleCodeExporter commented 9 years ago
No worries, I already fixed the labels.  ;)

Original comment by nicholas...@gmail.com on 29 Oct 2009 at 12:16

GoogleCodeExporter commented 9 years ago
OH yeah... now I remember why I changed that.

Because a host is just a machine/ ip address.  If you run multiple copies on a 
single 
instance, though, then using --host doesn't make sense.  Hence, the switch to --
instance.

Having said that, it's a minor point of correctness and I'm willing to 
compromise my 
hard fought morals, *sniff*, to make you happy.

(I'll get around to this when I remember, like I said to someone else, I've got 
a new 
version due out soon anyways.  Gimme a few days.  ;) )

Original comment by nicholas...@gmail.com on 29 Oct 2009 at 12:24

GoogleCodeExporter commented 9 years ago
Ahhh, right, that makes total sense. --help with some examples would be the best
improvement then!

Original comment by adam.ros...@gmail.com on 29 Oct 2009 at 12:27

GoogleCodeExporter commented 9 years ago
Actually, that's a great point.  One of those things I meant to do and forgot 
about.  
Hmm.  :)  Will work on it.

Original comment by nicholas...@gmail.com on 29 Oct 2009 at 1:19

GoogleCodeExporter commented 9 years ago
Marking this as invalid; I actually do think "instance" is more appropriate 
than "host".  However, I'm opening a new issue re: the lack of any help output, 
and I'll get around to fixing that.

Original comment by nicholas...@gmail.com on 7 Nov 2010 at 1:37