search

Leegh / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

Can PopSeccompStackFrame be removed from breakpad? #665

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
While investigating some WebView breakpad crashes (in the sense Breakpad 
crashing while handling a crash), we found out that there might be some bound 
check error in PopSeccompStackFrame (context: crrev.com/1290643003) which can 
lead into a segfault of the exception handler.

The bound check itself would be easy to fix. However we were just wondering 
whether the PopSeccompStackFrame code is required at all these days.
It looks like it was introduced only to deal with the legacy (non bpf) sandbox 
in Chrome, which has been deprecated in 2013.
If that is correct, can we remove that code from breakpad at all? Or is that 
any other non-chrome client out there which uses a legacy-seccomp with all the 
annex syscall trampoline black magic a-la chrome?

If that is the case (the PopSeccompStackFrame is not required anymore) I can 
prepare a patch to remove that.

Original issue reported on code.google.com by primi...@chromium.org on 14 Aug 2015 at 3:10

GoogleCodeExporter commented 9 years ago 
I worked on the old seccomp-sandbox 
(https://code.google.com/p/seccompsandbox/), and I can safely say that nothing 
uses it.  I'm not an owner of Breakpad, but I'm pretty sure you can remove 
PopSeccompStackFrame.

Original comment by mseaborn@chromium.org on 14 Aug 2015 at 6:41

GoogleCodeExporter commented 9 years ago

Original comment by rsesek@chromium.org on 14 Aug 2015 at 6:50