search

LeelaChessZero / lczero-client

The executable that communicates with the server to run selfplay games locally and upload results
71 stars 40 forks source link

option and default directory for config file #120

Closed borg323 closed 4 years ago

borg323 commented 4 years ago

With this, settings.json is renamed to lc0-training-client-config.json and is stored in $XDG_CONFIG_HOME or $HOME/.config in linux or $HOME//Library/Preferences in macos. The current directory is used under windows or if the environment variables are not defined.

The -config option is added to override the default file and location.

mooskagh commented 4 years ago

Most of the programs (but not all) create subdirectory inside .config/ do you think it doesn't make sense for the lc0 client?

borg323 commented 4 years ago

In this case it is a single file, but I suppose having a LeelaChessZero subdirectory potentially having other config files (e.g. lc0.config) makes sense.

mooskagh commented 4 years ago

There is not a single example of directory in my .config/ with capital letters in it. :)

borg323 commented 4 years ago

I have Qt and VirtualBox directories in my .config but definitely a minority. What would you prefer, leela-chess-zero, or lc0? Personally I prefer lc0, but this may confuse someone looking for the client config file.

borg323 commented 4 years ago

I think the logic is correct here, does not append 'lc0' if the path is empty.