LeftValues / leftvalues.github.io

LeftValues, a leftist political quiz
https://leftvalues.github.io/
Other
358 stars 74 forks source link

[WIP] Add French Translation #4

Closed salut-c-leo closed 4 years ago

salut-c-leo commented 5 years ago

I added a button to change between English and French, which should lead the way to other translations. To avoid creating multiple folders and thus duplicating files, I just created .fr.html and .fr.js files, so it would still depend on "static" files such as CSS files and images.

LeftValues commented 5 years ago

Looks great! However it would be good to convert it to the system used in the recently merged German translation, which should be relatively easy.

zeratax commented 5 years ago

Issues

Edit: I have no clue why the comparison here is so weird, but this one looks fine to me https://github.com/LeftValues/leftvalues.github.io/compare/master...mrtino:french-translation

zeratax commented 4 years ago

Okay fixed the merge conflicts and added

// TODO:

To all the missing translations so they're easily searchable

kwrothchild commented 4 years ago

We don't code, but my partner is a native French speaker and I am a native English speaker. We would like to help with the French translation. If you can tell us what still needs to be translated, we can help complete it. Cheers! K & T

zeratax commented 4 years ago

@kwrothchild wow that sounds awesome. I left // TODO: everywhere a french translation is still missing so you just need to add search for that in these files:

E.g. in ideologies the first line occurance is:

fr: {
        name: 'Marxisme-Léninisme'
        // TODO: Desc
      },

so you'll just have to turn that into something like:

fr: {
        name: 'Marxisme-Léninisme',
        desc: 'french description of Marxism-Leninism`
      },

The comma between new values is pretty important

It should be pretty clear by looking at the other languages in comparison

I hope you can just edit these files with the webinterface, I'm not super well versed with the github permission system.

If anything doesn't work that's no problem you can always ask or I'll just fix it myself ^^

kwrothchild commented 4 years ago

@ZerataX , Thanks so much! We have two questions: 1) For things that are not questions (i.e.) descriptions of the ideologies, is there somewhere where we can see what has been written in English so we can translate your working definition rather than writing a new definition ? 2) When clicking on the links to edit, it says that a "fork" is being created so the proposed changes will go to review. Is that correct/what we should be doing? Sorry if these are silly questions -- we are not coders! Just passionate about politics and language :) K&T

zeratax commented 4 years ago

@kwrothchild hey I just spend the night making this process a lot more straightforward (hopefully ^^) it's not yet actually in use, but I'm fairly sure it will be and you should definitely be able to already create translations with it, even if they won't immediately show up on the finished website until I hear back from the project owner.

I host this website here https://l10n.dmnd.sh/projects/leftvalues/leftvalues/fr/ which should have a very easy to understand interface where you can also always see the original english definition.

zeratax commented 4 years ago

so since the weblate branch is merged this is also merged and can be closed, even if the french translation is not yet done

kwrothchild commented 4 years ago

Thanks @ZerataX ! Much appreciated ! We are trying to coordinate a time to sit down together and work on this within the next week :)

kwrothchild commented 4 years ago

Hi @ZerataX , Sorry that we are slow. We went back to continue, and seems like there is a problem with https://l10n.dmnd.sh/projects/leftvalues/leftvalues/fr/ now -- when we click we get an error message.

zeratax commented 4 years ago

@kwrothchild sorry was doing some maintenance should be back up again