search

LeftyBC / weebullet

Weechat script to push notifications to Pushbullet
BSD 2-Clause "Simplified" License
28 stars 14 forks source link

Removed calls to string.decode() causing errors, and fix unreliable push notifications #25

Closed nathanvy closed 3 years ago

nathanvy commented 3 years ago

This fixes https://github.com/LeftyBC/weebullet/issues/24 and additionally fixed an issue where push notifications would not be sent if one was in a busy channel, due to the last_notification variable being set every time message_hook() was called.

I moved the line to update last_notification to the send_push() function instead, as it seems to me a more logical/sane place to perform that update.

h-bag commented 3 years ago

Why hasn't this been merged? Did the maintainers abandon it, or something?

nathanvy commented 3 years ago

Did the maintainers abandon it, or something?

I think so. You can pull from my fork, though. I've been running it on a Debian Stable box since I submitted this PR without issue.

h-bag commented 3 years ago

Did the maintainers abandon it, or something?

I think so. You can pull from my fork, though. I've been running it on a Debian Stable box since I submitted this PR without issue.

Yeah, I realized I could pull your fork a few hours ago. I've been up all night trying to get my IRC setup working how I want. Somehow, there's literally only 2 clients that work with the "weechat protocol". That's besides the point, though.

LeftyBC commented 3 years ago

Apologies, I don't use Weechat much these days.