search

Legacy-Fabric / fabric-loader-1.8.9

Fabric Loader for 1.8.9 and below
Apache License 2.0
12 stars 9 forks source link

Move Guava dependency from "server" to "common" #10

Open leo60228 opened 3 years ago

leo60228 commented 3 years ago

Guava is bundled with Minecraft, but on some versions (including 1.7.10) the bundled copy is too old. Explicitly installing Guava on the client is required for automated tools like MultiMC to work properly.

leo60228 commented 3 years ago

I didn't think the comment made sense considering that it's needed on the client too.

On Wed, May 12, 2021, 7:22 AM hYdos @.***> wrote:

@.**Ydos commented on this pull request.

In src/main/resources/fabric-installer.json https://github.com/Legacy-Fabric/fabric-loader-1.8.9/pull/10#discussion_r630951897 :

   {
  • "_comment": "jimfs in fabric-server-launch requires guava on the system classloader",

any reason for the comment removal?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Legacy-Fabric/fabric-loader-1.8.9/pull/10#pullrequestreview-657764253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7X32LH73M2SCHAT7Z5YILTNJQGRANCNFSM44VO4H4Q .