Fix selfkillother string format

Legacy-Players / LegacyPlayersV4

This project is a reboot of https://github.com/Geigerkind/LegacyPlayersV4 by Geigerkind, designed to resolve the scalability issues encountered by previous iterations and ensuring a smoother, richer experience for users.

https://legacyplayers.com/

GNU Affero General Public License v3.0

1 stars 5 forks source link

Fix selfkillother string format #37

Closed balakethelock closed 5 months ago

balakethelock commented 5 months ago

Changed formatting to match PARTYKILLOTHER PARTYKILLOTHER = "%s is slain by %s!" source: https://github.com/MOUZU/Blizzard-WoW-Interface/blob/d162a4c0d198a4381b5b6573d975635ed7316702/1.12.1/FrameXML/GlobalStrings.lua#L2988

The person doing the logging is on the right and the formatting for him is different. This changes it to be like his party members on the left.

melbaa commented 5 months ago

will make the backend recognize more events via RE_UNIT_SLAY https://github.com/Legacy-Players/LegacyPlayersV4/blob/8cd83675602a1ba6df34e58a034f4539f1d7bd6e/Backend/src/modules/live_data_processor/tools/cbl_parser/wow_vanilla/parser.rs#L136

melbaa commented 5 months ago

Probably for another PR but it think those are the same thing and the backend currently ignores them

INSTAKILLOTHER = "%s is killed by %s.";
INSTAKILLSELF = "You are killed by %s.";

balakethelock commented 5 months ago

Probably for another PR but it think those are the same thing and the backend currently ignores them
INSTAKILLOTHER = "%s is killed by %s.";
INSTAKILLSELF = "You are killed by %s.";

These are only printed by the client in the case of receiving an INSTAKILL opcode by the server. The server only sends those on instakill spells which are mostly creatures suiciding as part of a mechanic.

As shown here in a naxx log, this is just some warlock pets dying to Demonic Sacrifice and the frogger slimes after Patchwerk suiciding over and over.

So I think it's better to ignore them in the backend parser