LegalizeAdulthood / manx

Source for the manx vintage computer documentation database.
http://manx-docs.org
GNU General Public License v2.0
7 stars 2 forks source link

URLs with special characters aren't checked for existence properly #68

Open LegalizeAdulthood opened 5 years ago

LegalizeAdulthood commented 5 years ago

When URLs are stored in the database, they sometimes don't have their special characters (#, space, etc.) URL encoded. This means that when we do a text lookup for the URL in the database, we don't find it. If looking for the URL encoded url doesn't turn up a match, we should URL decode the special characters from the URL and search again, just to be sure it doesn't appear without the special characters encoded.

This is a high impact bug because it means we could enter duplicate documents and URLs.