search

Legend-of-Dragoon-Modding / Script-Recompiler

A disassembler for the Legend of Dragoon scripting engine
GNU Affero General Public License v3.0
0 stars 2 forks source link

Multiple issues in DRGN21/33 #10

Open theflyingzamboni opened 1 year ago

theflyingzamboni commented 1 year ago 
2023-09-02 13:57:04.271 [ForkJoinPool.commonPool-worker-1 org.legendofdragoon.scripting.launch.Decompile:62] INFO : G:\Disassembled Scripts\33\1.txt
2023-09-02 13:57:04.271 [ForkJoinPool.commonPool-worker-1 org.legendofdragoon.scripting.launch.Decompile:63] ERROR: CALL 227 has wrong number of args! 0/1
2023-09-02 13:57:04.285 [ForkJoinPool.commonPool-worker-1 org.legendofdragoon.scripting.launch.Decompile:57] INFO : G:\Disassembled Scripts\33\2.txt
2023-09-02 13:57:04.285 [ForkJoinPool.commonPool-worker-1 org.legendofdragoon.scripting.launch.Decompile:58] ERROR: Entrypoint scan failed, index out of bounds
2023-09-02 13:57:04.304 [ForkJoinPool.commonPool-worker-1 org.legendofdragoon.scripting.launch.Decompile:57] INFO : G:\Disassembled Scripts\33\3.txt
2023-09-02 13:57:04.304 [ForkJoinPool.commonPool-worker-1 org.legendofdragoon.scripting.launch.Decompile:58] ERROR: Entrypoint scan failed, index out of bounds
2023-09-02 13:57:04.312 [ForkJoinPool.commonPool-worker-1 org.legendofdragoon.scripting.launch.Decompile:57] INFO : G:\Disassembled Scripts\33\4.txt
2023-09-02 13:57:04.312 [ForkJoinPool.commonPool-worker-1 org.legendofdragoon.scripting.launch.Decompile:58] ERROR: Entrypoint scan failed, index out of bounds
LordMonoxide commented 1 year ago

33/1 uses a lot of no-op methods and unimplemented ones. Updated a bunch to have the correct number of params, but it calls 8001fe28 (another unimplemented method) with one param, which is incorrect (it should have two). Unsure how to proceed with that.

LordMonoxide commented 1 year ago

33/2 and 33/3 both only pass one param to the same method, and also seem to use a jump table that would be after the end of the script

theflyingzamboni commented 1 year ago

Innnnteresting. These are the scripts for the scene where Dart runs up the hill and sees Seles. So they are used scripts, but I guess there are dead branches.