Does not go full screen on KDE Plasma desktop (Which is also used on the Steam Deck as its desktop)

Legend-of-Dragoon-Modding / Severed-Chains

Legend of Dragoon decompiled, reverse engineered, and ported to Java

https://legendofdragoon.org/projects/severed-chains/

255 stars 19 forks source link

Does not go full screen on KDE Plasma desktop (Which is also used on the Steam Deck as its desktop) #1129

Open linlinxza opened 5 months ago

linlinxza commented 5 months ago

Does not go fullscreen on KDE Plasma

This may affect anyone else who uses other desktop environments on Linux. I'd test the major ones like GNOME and Cinnamon as well.

As of commit https://github.com/Legend-of-Dragoon-Modding/Severed-Chains/commit/f4885076eb9269d5b856792969acb53afea33bee

LordMonoxide commented 5 months ago

Looks like the window was resized down so that it didn't overlap the taskbar
Disabling title bar and frame in the window options makes it work as expected
Gonna have to look into glfw's window options and see if they have any documentation on interacting with various Linux window managers

linlinxza commented 5 months ago

Yeah. It's just the lower panel that the window needs to be able to overlap when in full screen mode. I think once this is fixed, it will work on any desktop just fine.

Keep in mind that there is an iffy text rendering issue with your recent commit still with regards to dialog boxes.