Legend-of-Dragoon-Modding / Severed-Chains

Legend of Dragoon decompiled, reverse engineered, and ported to Java
https://legendofdragoon.org/projects/severed-chains/
292 stars 23 forks source link

Crash when Struck by Thunder Arrow #1704

Open Wulves opened 6 months ago

Wulves commented 6 months ago

Describe the bug Game crashed when Haschel was hit by Thunder Arrow. This could be an issue with Thunder Arrow itself, or it might be an issue with the status effect immunity animation since TA inflicts stun but Haschel was guarding rendering him immune.

https://github.com/Legend-of-Dragoon-Modding/Severed-Chains/assets/170744536/3caf1763-034b-468f-a4da-ab707c48b19c

Crash Log for Archer

Wulves commented 6 months ago

Had Albert guarding against the stinger's poison attack and the immune animation played with no issue, so it's likely this is just a Thunder Arrow issue

LordMonoxide commented 5 months ago

I can't reproduce this and have no idea how it could even happen

Wulves commented 5 months ago

This might have something to do with it. Lightning appears at the top of the screen when struck with the arrow (don't think it's supposed to do that)

https://github.com/Legend-of-Dragoon-Modding/Severed-Chains-Public-Test/assets/170744536/3dd7a273-f1ec-4465-8ac7-ddfec5ec3bd7

Wulves commented 5 months ago

I uh, yeah I have no clue other than to say this is sometimes inconsistent. Thunder Arrow twice in a row, no difference between camera angle or anything. 1st one no crash, 2nd one crashes the game. You can just make out the thunder in the top left hand corner btw as a few pixels lighting up.

https://github.com/Legend-of-Dragoon-Modding/Severed-Chains-Public-Test/assets/170744536/e2c93bed-d16b-4846-b881-3a2f24264de7

Wulves commented 4 months ago

Had a different error message in the logs this time

Thunder Arrow Crash Log 2

Zychronix commented 1 month ago

Literally go into battle with Arrow Shooter, set turn meter to 9999 and pray.

java.lang.NullPointerException: Cannot invoke "org.joml.Vector3ic.x()" because "v" is null at org.joml.Vector3i.sub(Vector3i.java:688) at org.joml.Vector3i.sub(Vector3i.java:684) at legend.game.combat.SEffe.tickThunderArrowEffect(SEffe.java:1109) at legend.game.scripting.ScriptState.tick(ScriptState.java:191) at legend.game.scripting.ScriptManager.executeScriptTickers(ScriptManager.java:224) at legend.game.scripting.ScriptManager.tick(ScriptManager.java:70) at legend.game.Scus94491BpeSegment.lambda$gameLoop$45(Scus94491BpeSegment.java:423) at legend.core.RenderEngine.lambda$init$17(RenderEngine.java:504) at legend.core.opengl.Window$Events.onDraw(Window.java:697) at legend.core.opengl.Window.tickFrame(Window.java:337) at legend.core.opengl.Action.run(Action.java:46) at legend.core.opengl.Action.tick(Action.java:32) at legend.core.opengl.Window.run(Window.java:314) at legend.core.RenderEngine.run(RenderEngine.java:1131) at legend.core.GameEngine.start(GameEngine.java:251)

replay_pid43908.log

at legend.game.Main.main(Main.java:24)
ameyer117 commented 1 month ago

Same issue as others, I'm using the latest dev build:

java.lang.IllegalArgumentException
    at org.joml.MemUtil$MemUtilNIO.set(MemUtil.java:2803)
    at org.joml.Matrix3f.set(Matrix3f.java:3251)
    at legend.game.combat.SEffe.renderThunderArrowEffect(SEffe.java:1089)
    at legend.game.scripting.ScriptState.render(ScriptState.java:205)
    at legend.game.scripting.ScriptManager.executeScriptRenderers(ScriptManager.java:248)
    at legend.game.scripting.ScriptManager.tick(ScriptManager.java:72)
    at legend.game.Scus94491BpeSegment.lambda$gameLoop$45(Scus94491BpeSegment.java:423)
    at legend.core.RenderEngine.lambda$init$17(RenderEngine.java:504)
    at legend.core.opengl.Window$Events.onDraw(Window.java:697)
    at legend.core.opengl.Window.tickFrame(Window.java:337)
    at legend.core.opengl.Action.run(Action.java:46)
    at legend.core.opengl.Action.tick(Action.java:32)
    at legend.core.opengl.Window.run(Window.java:314)
    at legend.core.RenderEngine.run(RenderEngine.java:1131)
    at legend.core.GameEngine.start(GameEngine.java:251)
    at legend.game.Main.main(Main.java:24)