search

Legend-of-iPhoenix / cemetech-userstyle

iPhoenix's Spiffy Cemetech Userstyle
MIT License
9 stars 4 forks source link

Add karma count to user profiles #35

Closed commandblockguy closed 3 years ago

commandblockguy commented 3 years ago

This is currently somewhat broken, as the DecBot API doesn't support links (see this post). However, it still works for users whose Cemetech username is the "root" name that DecBot links other names to. Depending on how the API is fixed, this will probably either magically work in the future or require a call to an API for getting links for a user.

Legend-of-iPhoenix commented 3 years ago

I'll wait to merge until https://www.cemetech.net/forum/viewtopic.php?p=293840#293840 is fixed, optionally waiting for https://www.cemetech.net/forum/viewtopic.php?t=17779 if I feel like it

Legend-of-iPhoenix commented 3 years ago

Actually, if this is completely harmless to merge without the API change I could merge this, like, now.

My initial reasoning for not merging this immediately was that the second possibility ("require a call to an API for getting links for a user") is an API change and we should wait for this API change to be implemented before doing anything else with the API. After some more thought, I'm inclined to believe that I was wrong here, perhaps being overly cautious. Even if the separate API call for resolving links is the way they go, it shouldn't hurt that things are added.

cc @commandblockguy