Feature: Missing `ItemSeparatorComponent`, `ListEmptyComponent`, `ListFooterComponent`, `showsVerticalScrollIndicator`, `inverted`,

LegendApp / legend-list

MIT License

339 stars 9 forks source link

Feature: Missing `ItemSeparatorComponent`, `ListEmptyComponent`, `ListFooterComponent`, `showsVerticalScrollIndicator`, `inverted`, #6

Open imranbarbhuiya opened 4 days ago

imranbarbhuiya commented 4 days ago

[x] ItemSeparatorComponent
[ ] ListEmptyComponent
[x] ListFooterComponent
[x] ListeHeaderComponent
[ ] showsVerticalScrollIndicator
[ ] ref scrollToIndex
[ ] ref scrollToItem
[x] ~~inverted~~ ref: https://reactnative.dev/docs/flatlist

jmeistrich commented 4 days ago

ListeHeaderComponent and ListFooterComponent were added in 0.1.2 by https://github.com/LegendApp/legend-list/pull/3.

I think inverted will not be added because we will support chat-like views in a better way. But please let me know if you have a different reason for wanting inverted.

Thanks for creating a tracking issue for other missing props! Please feel free to submit a PR to add the others, I'm focusing on some other things first.

imranbarbhuiya commented 3 days ago

ok thanks, I need inverted for chat only so if you are adding a better way of doing it then it's great

huextrat commented 3 days ago

showsVerticalScrollIndicator & showsHorizontalScrollIndicator should already work, given the implementation, and it seems to work

Have you seen any non-functional behavior with these two props?

PR for ItemSeparatorComponent: https://github.com/LegendApp/legend-list/pull/8

jmeistrich commented 3 days ago

I added a chat-like feature in 0.2.1. See https://github.com/LegendApp/legend-list/pull/2 for some discussion of that. Does that effectively solve the usage you were wanted inverted for?

imranbarbhuiya commented 3 days ago

@huextrat you are right, I had it disabled for ios only and was checking in Android